Only parse import uris if stated - #193
Conversation
| uri = "s3://" + path | ||
|
|
||
| if not uri.startswith("/"): | ||
| uri = format_s3_uri(uri, endpoint) |
There was a problem hiding this comment.
Has it been tested with the new format ?
There was a problem hiding this comment.
If the extinfo URL is http then the format doesn't matter (doesn't care about what part of the URL is the endpoint, bucket, etc).
For the option to convert http url into S3: That would actually need another flag to specify if the provided URL is host or path-style format. Is it worth adding that, as this option is actually not really needed any longer?
will-moore
left a comment
will-moore
left a comment
There was a problem hiding this comment.
Code looks fine.
I think it would be useful to document when you don't (or DO) need to --parseuri.
In the argument help it could say "This is required if you are using omero-zarr-pixel-buffer version ??? or earlier". And add a note in the repo README where it describes the "import" option
|
Conflicting PR. Removed from build OMERO-plugins-push#52. See the console output for more details.
--conflicts |
for more information, see https://pre-commit.ci
4 participants
With ome/omero-zarr-pixel-buffer#13 it won't be necessary any longer to translate http into s3 URLs. The option is still available but only when explicetely stated (via
--parseuriflag).