Skip to content

Physical sizes for subresolutions - #4479

Draft
melissalinkert wants to merge 8 commits into
ome:developfrom
melissalinkert:pyramid-physical-sizes
Draft

Physical sizes for subresolutions#4479
melissalinkert wants to merge 8 commits into
ome:developfrom
melissalinkert:pyramid-physical-sizes

Conversation

@melissalinkert

@melissalinkert melissalinkert commented Aug 13, 2026

Copy link
Copy Markdown
Member

Fixes #3797. Opening as draft for now as this needs work, but I wanted to capture current progress before switching to other tasks.

Following discussion of 9.0.0 with @ome/formats earlier this week, I think I feel better about the idea of calculating physical pixel sizes for subresolutions in the case where resolutions are flattened. We also already have one reader (DicomReader) that reports a different physical pixel size for each flattened resolution; this is because each resolution's size is stored separately (since one resolution per file).

The current state of this pull request adds some minimal API to FormatTools so we don't have to re-implement calculation in each reader, and updates appropriate BSD readers to make use of it. Only readers that need to be updated are ones that meet all 3 criteria:

  • make use of pyramids, i.e. set CoreMetadata.resolutionCount to something other than 1
  • report a physical pixel size, i.e. call store.setPixelsPhysicalSize*
  • represent a format that does not store a separate physical size for each resolution

I expect the following readers would still need to be updated:

This will require configuration updates for any datasets that make use of the updated readers. I also note that we don't have a .fake example that uses both pyramids and physical sizes, so at least one example of that will need to be added to the test repo.

@melissalinkert melissalinkert added this to the 9.0.0 milestone Aug 13, 2026
@melissalinkert melissalinkert added the RC2 9.0.0-rc2 label Sep 2, 2026
Also sets channel names etc. for each resolution.
Also makes sure some other metadata (e.g. channel names) are populated
for flattened sub-resolutions.
@melissalinkert

Copy link
Copy Markdown
Member Author

Planned work is now done here, and draft of config updates is in https://github.com/ome/data_repo_config/pull/726. I have not yet added new sample data, but can do that once we're ready to include this in builds. We can think about a plan for inclusion after 9.0.0-rc1 (I have this tentatively labeled for 9.0.0-rc2, but we can discuss if that's reasonable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RC2 9.0.0-rc2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When opening the different resolution series from a BDV xml/hdf5 file, the properties has incorrect image dimensions.

1 participant