Skip to content

Solution for issue #34 "Multiple parsers on one ESP?" and potential solution for issue #32 Parsing of the device id #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Roland-Schneider
Copy link

  • Solution for issue Multiple parsers on one ESP? #34 "Multiple parsers on one ESP?"
    Provide sml_parser functionality through new class SmlParser which provides parser state and cache buffers per instance (opposed to previous static buffers).
    This allows concurrent handling of multiple smart meter devices with the same program.
  • Potential solution for issue Parsing of the device id (96.1.0) #32 "Parsing of the device id":
    Provide new function smlOBISServerId to obtain OBIS server id 1-0:0.0.9*255

…lParser which provides parser state and cache buffers per instance, opposed to previous static buffers. This allows concurrent handling of multiple smart meter devices with the same program. Issue olliiiver#32: Provide new function smlOBISServerId to obtain OBIS server id 1-0:0.0.9*255
@Roland-Schneider
Copy link
Author

@olliiiver oder @CRSLEE
Please have a look into this pull request and check if it makes sense and can be merged.
Codacy findings seem to be useless false positives from my point of view, memcpy is used the same way as in smlOBISManufacturer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant