Skip to content

Cancel keep alive on close #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cancel keep alive on close #34

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fda5449
Cancel keep alive if client gets disconnected from server
jjok Dec 30, 2018
c1a2a45
Remove unused Timer reference
jjok Dec 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/MqttClient.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
use oliverlorenz\reactphpmqtt\protocol\Version;
use oliverlorenz\reactphpmqtt\protocol\Violation as ProtocolViolation;
use React\EventLoop\LoopInterface as Loop;
use React\EventLoop\Timer\Timer;
use React\Promise\Deferred;
use React\Promise\FulfilledPromise;
use React\Promise\PromiseInterface;
Expand Down Expand Up @@ -107,10 +106,14 @@ private function keepAlive(Connection $stream, $keepAlive)
if($keepAlive > 0) {
$interval = $keepAlive / 2;

$this->getLoop()->addPeriodicTimer($interval, function(Timer $timer) use ($stream) {
$timer = $this->getLoop()->addPeriodicTimer($interval, function() use ($stream) {
$packet = new PingRequest($this->version);
$this->sendPacketToStream($stream, $packet);
});

$stream->on('close', function() use ($timer) {
$this->getLoop()->cancelTimer($timer);
});
}

return new FulfilledPromise($stream);
Expand Down