-
Notifications
You must be signed in to change notification settings - Fork 94
e-mail attachment flow #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bikubi
wants to merge
19
commits into
main
Choose a base branch
from
bikubi/email-att-flow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
e-mail attachment flow #1079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bikubi
commented
Jul 23, 2025
- implement similar to / within post-upload
- different intro
- with pdf redaction
- different flow: keep request update parts (status etc.), remove/skip message parts (date etc.)
- update link in notification e-mails -- tested only up to a point, could not simulate this specific e-mail locally...
- renamed "post-upload" to "edit-message-flow", because it is used for non-postal e-mails now, too.
- other ideas welcome.. i only had "message-upsert" as an alt :)
- arguably edit-message-flow.vue (née post-upload.vue) could be split into sub-components, but with the flow graph, one-big-component-which-does-two-things might be the lesser evil
- nb. https://github.com/okfde/fragdenstaat_de/tree/bikubi/email-att-flow matches the renames
34e90d5 to
1e35cb6
Compare
f03204a to
41129cc
Compare
plus translation update
e.g. docx, which has to go through libreoffice; in lieu of signal/websocket/FoiAttachment.pending
41129cc to
b33d736
Compare
Contributor
Author
|
@krmax44 update summary:
⇒ if the form workaround is OK, feel free to review |
bikubi
commented
Aug 6, 2025
|
|
||
| def fails_authenticity(self): | ||
| if not self.is_response or not self.is_email: | ||
| if not self.is_response or not self.is_email or not self.email_headers: |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krmax44 this fixed this failed run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.