Skip to content

Test4 - #9

Merged
ojsef39 merged 5 commits into
mainfrom
test4
Mar 14, 2026
Merged

ojsef39 merged 5 commits into
mainfrom
test4

Conversation

@ojsef39

@ojsef39 ojsef39 commented Mar 14, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings March 14, 2026 13:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the flake-review GitHub Actions workflow from a Nix-based installation (nix run with a flake ref) to a pip-based installation (from git or checkout). It also replaces Cachix caching with magic-nix-cache-action, adds a --character-oriented flag to nix-diff, and introduces a new packages input for filtering which packages to review.

Changes:

  • Replaced Nix flake-ref based installation/invocation with pip-based install and direct flake-review CLI invocation in the reusable workflow.
  • Added --character-oriented flag to nix-diff command in report.py.
  • Added new packages workflow input to allow filtering reviewed packages, and removed Cachix secrets/configuration in favor of magic-nix-cache-action.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
flake_review/report.py Added --character-oriented flag to the nix-diff command.
.github/workflows/flake-review.yml Updated self-test workflow to use install-from-checkout: true instead of flake-ref, removed Cachix secret.
.github/workflows/flake-review-reusable.yml Major refactor: pip-based install, new packages/install-from-checkout/flake-review-ref inputs, replaced Cachix with magic-nix-cache, direct CLI invocation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/flake-review-reusable.yml Outdated
Comment thread .github/workflows/flake-review-reusable.yml
Comment thread .github/workflows/flake-review-reusable.yml Outdated
@github-actions

github-actions Bot commented Mar 14, 2026 •

Copy link
Copy Markdown

Flake Review Results for #9

Available systems: aarch64-darwin, aarch64-linux, x86_64-darwin, x86_64-linux
Requested systems: aarch64-darwin, aarch64-linux, x86_64-darwin, x86_64-linux

🔄 Modified (8)

  • ✅ packages.aarch64-darwin.default

    • Output: /nix/store/5zs7vs1hfhhc63zv656g7jya4firyd1v-flake-review-0.1.0
    Derivation diff
    - /nix/store/jxjn1wic0gairx8dih7va50ha1hs01m8-flake-review-0.1.0.drv:{out}
    + /nix/store/prjy9si49jq6g9v3nhbi4pfqx8dq3nvn-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        /nix/store/←4←→lc1sxcaxh→m→df→w←2l24mfii←→v→0←jza5hxjj←→sc→b→9pzcrpd8jkza→3←fad14s6a6m←→j→-source
    ''
  • ✅ packages.aarch64-darwin.flake-review

    • Output: /nix/store/5zs7vs1hfhhc63zv656g7jya4firyd1v-flake-review-0.1.0
    Derivation diff
    - /nix/store/jxjn1wic0gairx8dih7va50ha1hs01m8-flake-review-0.1.0.drv:{out}
    + /nix/store/prjy9si49jq6g9v3nhbi4pfqx8dq3nvn-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        /nix/store/←4←→lc1sxcaxh→m→df→w←2l24mfii←→v→0←jza5hxjj←→sc→b→9pzcrpd8jkza→3←fad14s6a6m←→j→-source
    ''
  • ✅ packages.x86_64-darwin.default

    • Output: /nix/store/0p4if2ccalmqqzcgjcx7srxv6wbyks7d-flake-review-0.1.0
    Derivation diff
    - /nix/store/3ybp1xkffp2g4m23rxj333l2y8bfqcs9-flake-review-0.1.0.drv:{out}
    + /nix/store/chlpprgvc22ppwk0d674khsdr3r5q43v-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        /nix/store/←4←→lc1sxcaxh→m→df→w←2l24mfii←→v→0←jza5hxjj←→sc→b→9pzcrpd8jkza→3←fad14s6a6m←→j→-source
    ''
  • ✅ packages.x86_64-darwin.flake-review

    • Output: /nix/store/0p4if2ccalmqqzcgjcx7srxv6wbyks7d-flake-review-0.1.0
    Derivation diff
    - /nix/store/3ybp1xkffp2g4m23rxj333l2y8bfqcs9-flake-review-0.1.0.drv:{out}
    + /nix/store/chlpprgvc22ppwk0d674khsdr3r5q43v-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        /nix/store/←4←→lc1sxcaxh→m→df→w←2l24mfii←→v→0←jza5hxjj←→sc→b→9pzcrpd8jkza→3←fad14s6a6m←→j→-source
    ''
  • ✅ packages.aarch64-linux.default

    • Output: /nix/store/hmh8rz2kvv5wdzbm07lwb3svvpyvb6vg-flake-review-0.1.0
    Derivation diff
    - /nix/store/nbnqr442x2r8vhwxbafdswqsmxf7sr8d-flake-review-0.1.0.drv:{out}
    + /nix/store/qf869qjjdscqg4dfcm2iszpnnciky9bg-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        /nix/store/←4←→lc1sxcaxh→m→df→w←2l24mfii←→v→0←jza5hxjj←→sc→b→9pzcrpd8jkza→3←fad14s6a6m←→j→-source
    ''
  • ✅ packages.aarch64-linux.flake-review

    • Output: /nix/store/hmh8rz2kvv5wdzbm07lwb3svvpyvb6vg-flake-review-0.1.0
    Derivation diff
    - /nix/store/nbnqr442x2r8vhwxbafdswqsmxf7sr8d-flake-review-0.1.0.drv:{out}
    + /nix/store/qf869qjjdscqg4dfcm2iszpnnciky9bg-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        /nix/store/←4←→lc1sxcaxh→m→df→w←2l24mfii←→v→0←jza5hxjj←→sc→b→9pzcrpd8jkza→3←fad14s6a6m←→j→-source
    ''
  • ✅ packages.x86_64-linux.default

    • Output: /nix/store/i65qr1q7r25fnv78b6hbd2rn8qqs440p-flake-review-0.1.0
    Derivation diff
    - /nix/store/gf0c6sb1531imbzl3r4j3dgp3bg3wi0l-flake-review-0.1.0.drv:{out}
    + /nix/store/p83ilddr1r5rp6xii2g39sfl3rzpr89h-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        /nix/store/←4←→lc1sxcaxh→m→df→w←2l24mfii←→v→0←jza5hxjj←→sc→b→9pzcrpd8jkza→3←fad14s6a6m←→j→-source
    ''
  • ✅ packages.x86_64-linux.flake-review

    • Output: /nix/store/i65qr1q7r25fnv78b6hbd2rn8qqs440p-flake-review-0.1.0
    Derivation diff
    - /nix/store/gf0c6sb1531imbzl3r4j3dgp3bg3wi0l-flake-review-0.1.0.drv:{out}
    + /nix/store/p83ilddr1r5rp6xii2g39sfl3rzpr89h-flake-review-0.1.0.drv:{out}
    • The input source named `source` differs
    • The environments do not match:
        src=''
        /nix/store/←4←→lc1sxcaxh→m→df→w←2l24mfii←→v→0←jza5hxjj←→sc→b→9pzcrpd8jkza→3←fad14s6a6m←→j→-source
    ''

Generated by flake-review

@ojsef39
ojsef39 merged commit feede18 into main Mar 14, 2026
5 checks passed
@ojsef39
ojsef39 deleted the test4 branch March 14, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants