fix(search): server-side type filter so --max applies after --type

[frd1201]

Problem

vsp search "Z*" --type CLAS --max 50 returned fewer results than expected (issue #119).

The ADT server returned up to --max mixed-type objects, and --type was applied client-side afterwards — so any CLAS objects outside the first 50 mixed results were silently dropped.

Solution

Add SearchObjectByType that passes objectType to the ADT informationsystem/search endpoint so the server filters before applying maxResults. SearchObject becomes a thin shim, leaving all existing callers untouched.

Short-form types are canonicalized at the CLI boundary (CLAS→CLAS/OC, INTF→INTF/OI, PROG→PROG/P, etc.) via canonicalObjectType. --verbose prints the effective query for debugging.

Test plan

• vsp search "Z*" --type CLAS --max 50 returns up to 50 CLAS objects
• vsp search "Z*" (no --type) still works unchanged
• Unit tests in pkg/adt/client_test.go pass

Closes #119

[txape10]

Tested on-prem (on-premise SAP). Two follow-up points worth noting for whoever merges this:

1. MCP handler was not wired up

The fix in runSearch (CLI path) is correct, but handlers_search.go (SAP(action="search") in hyperfocused mode) was still calling SearchObject — so the MCP path had the same bug: type param was ignored and max applied after client-side filtering.

Fix: wire handleSearchObject to SearchObjectByType and accept type/objectType/max params in routeSearchAction.

2. canonicalObjectType belongs in the adt package

Having it in cli.go means MCP callers would need to duplicate the mapping or bypass it. Moving it to adt.CanonicalObjectType (exported) and calling it inside SearchObjectByType means every caller — CLI, MCP, or direct API — gets short-form expansion automatically with no extra work.

Both changes are in my branch if useful: https://github.com/txape10/vibing-steampunk/tree/fix/lock-nomodification-with-transport

[frd1201]

Thanks @txape10, this was really helpful — appreciate you testing on-prem and pinning down both the MCP wiring gap and the package placement. Implemented both: the MCP path (handleSearchObject/routeSearchAction) now goes through SearchObjectByType and accepts type/objectType + max/maxResults, and CanonicalObjectType is exported in the adt package and applied inside SearchObjectByType, so CLI, MCP and direct API callers all get short-form expansion. Also pulled in the extra mappings from your branch (INCL→PROG/I, TTYP, ENQU). Would be great if you could take another look!