feat(version-source): mirror setuptools_scm override env vars for version #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@ofek ready for review. |
Collaborator
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
I think we should mirror the env vars setuptools_scm has for overrides/pretend versions
…sion Support SETUPTOOLS_SCM_PRETEND_VERSION and SETUPTOOLS_SCM_PRETEND_VERSION_FOR_<DIST_NAME> for version override, aligning with setuptools_scm conventions as requested in PR review. Also update tests to verify override precedence and compatibility.
Switch override environment variables from SETUPTOOLS_SCM to HATCH_VCS for version control, as requested in PR review. Tests updated to match new variable names and precedence.
Author
|
Thank you for the feedback @RonnyPfannschmidt. Do the changes that I made align with your suggestion? Let me know if it should be altered even further. |
millsks
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We use hatch-vcs in all of our projects. There is a specific version format that they push to us on our build pipeline to align with their SCM reporting. The HATCH_VERSION_OVERRIDE variable will allow me to set that prior to our build so that their requirement is being used.
If this variable is not set then then default behavior takes over.