18.0 training rvar #848

rvar-odoo · 2025-07-09T10:17:17Z

This PR adds demo data to the estate module as per the Odoo Estate tutorial.

Features:

-Estate module initialization and configuration
-Property model definition with key fields
-Basic list and form views
-Menu and action setup for navigation
-Implemented Inheritance

Created new 'estate' module. Added base model 'estate.property' with fields mentioned in exercise. Set up module structure. Set 'name' and 'expected_price' as required fields.

This commit introduces the initial version of the module as part of the Odoo 18 developer tutorial. The module includes basic models, access rights, security rules, and simple form and tree views for managing real estate properties. The purpose of this change is to set up a foundational structure for the module. It follows the official tutorial steps to demonstrate Odoo’s ORM, security mechanisms, and view definitions. Adding proper access control ensures that only authorized users can interact with the module. The initial UI provides the groundwork for extending functionality later. This is part of a learning exercise to understand Odoo’s server framework and how to implement a feature-rich module following best practices.

robodoo · 2025-07-09T10:17:19Z

This commit enhances the module by introducing relational fields (many2one, one2many, and many2many), computed fields with dependencies, onchange methods for dynamic form updates, and server actions to extend business logic. The motivation for these changes is to provide a richer data model and dynamic behavior in the estate management workflow. Relations connect properties to users and offers, improving data integrity. Computed and stored fields enable automatic updates (e.g., total area or best offer). Onchange handlers improve UX by pre-filling or validating data at the form level. Server actions and automated behaviors lay the groundwork for more complex business processes. These improvements align with Odoo’s design philosophy of reactive and modular business logic while maintaining clear separation between models and views.

This commit enhances the estate module by introducing relational fields (many2one, one2many, and many2many), computed fields with dependencies, onchange methods for dynamic form updates, and server actions to extend business logic. The motivation for these changes is to provide a richer data model and dynamic behavior in the estate management workflow. Relations connect properties to users and offers, improving data integrity. Computed and stored fields enable automatic updates (e.g., total area or best offer). Onchange handlers improve UX by pre-filling or validating data at the form level. Server actions and automated behaviors lay the groundwork for more complex business processes. These improvements align with Odoo’s design philosophy of reactive and modular business logic while maintaining clear separation between models and views.

Added SQL constraints to ensure: Property expected price is strictly positive Property selling price is positive Offer price is strictly positive Property tag name and property type name are unique Added Python constraint to prevent selling price from being set below 90% of expected price Changes in UI: Added inline list view for properties on property type form Used statusbar widget for property state display Defined default ordering for models and enabled manual ordering for property types via sequence field Applied widget options to restrict creation/editing of property types from property form

- Added model and view inheritance for extending existing functionality. - Implemented interaction with external modules using dependencies. - Updated estate module to demonstrate cross-module field access and method calls.

- Implemented cross-module field access and method calls to demonstrate interaction with other modules. - Cleaned codebase to fix linter errors and improve readability.

maad-odoo

Quick first review.

Remove the unnecessary diff added in the code base.
Also the PR title is not correct, please adapt that as well

maad-odoo · 2025-07-10T17:58:24Z

estate/__init__.py

@@ -0,0 +1 @@
+from . import models


Missing licensing

maad-odoo · 2025-07-10T17:58:49Z

estate/__manifest__.py

+    "installable": True,
+    "depends": ["base"],
+    "application": True,
+    "auto_install": False,


If the value is false, then no need to define it anyways

maad-odoo · 2025-07-10T17:59:10Z

estate/__manifest__.py

+    "summary": "Demo app for estate",
+    "description": "This is the demo app ",


Add a proper summary and description

maad-odoo · 2025-07-10T18:00:39Z

estate/models/estate_property.py

+class RecurringPlan(models.Model):
+    _name = "estate.property"
+    _description = "estate property revenue plans"


Mismatch class name and model name

maad-odoo · 2025-07-10T18:00:51Z

estate/models/estate_property.py

+class RecurringPlan(models.Model):
+    _name = "estate.property"
+    _description = "estate property revenue plans"
+    _order = "id desc"  # For ordering in ascending opr descending order   one more way to do so is from view like: <list default_order="date desc">


Comment is not required here

maad-odoo · 2025-07-10T18:05:35Z

estate/models/estate_property_offer.py

+            # Allow only if property has no accepted offer
+            if offer.property_id.buyer_id:
+                raise UserError(
+                    _("An offer has already been accepted for this property.")
+                )
+            # Set buyer and selling price
+            offer.property_id.buyer_id = offer.partner_id
+            offer.property_id.selling_price = offer.price
+            offer.status = "accepted"
+            offer.property_id.state = "offer_accepted"
+            # Setting remaining Offer as refused
+            other_offers = offer.property_id.offer_id - offer
+            # for other in other_offers:                  # -----> Normal for loop logic
+            #     other.status = 'refused'
+            other_offers.write({"status": "refused"})  # -----> Odoo ORM Method


Comment are unnecesary

maad-odoo · 2025-07-10T18:06:13Z

estate/models/estate_property_offer.py

+
+        return super().create(new_records)
+
+        # vals_list---------> [{'partner_id': 23, 'price': 100, 'validity': 7, 'date_deadline': '2025-07-16', 'property_id': 19}]


Unnecessary

maad-odoo · 2025-07-10T18:06:28Z

estate/security/ir.model.access.csv

+access_estate_model,estate.property,model_estate_property,base.group_user,1,1,1,1
+access_estate_model_property,estate.property.type,model_estate_property_type,base.group_user,1,1,1,1
+access_estate_model_tag,estate.property.tag,model_estate_property_tag,base.group_user,1,1,1,1
+access_estate_model_offer,estate.property.offer,model_estate_property_offer,base.group_user,1,1,1,1


End of file line is missing

maad-odoo · 2025-07-10T18:06:53Z

estate/views/res_users_views.xml

+    </field>
+
+</record>
+</odoo>


End of file line is missing

maad-odoo · 2025-07-10T18:07:58Z

estate_account/models/estate_property.py

+            journal = self.env["account.journal"].search(
+                [("type", "=", "sale")], limit=1
+            )


Do you think searching inside for loop is efficient way to do it ?

rvar-odoo added 2 commits July 2, 2025 19:02

[ADD] estate: initial module for real estate properties

1db8870

Created new 'estate' module. Added base model 'estate.property' with fields mentioned in exercise. Set up module structure. Set 'name' and 'expected_price' as required fields.

rvar-odoo added 5 commits July 10, 2025 11:53

[IMP] estate: add inheritance and module interaction features

8235948

- Added model and view inheritance for extending existing functionality. - Implemented interaction with external modules using dependencies. - Updated estate module to demonstrate cross-module field access and method calls.

[IMP] estate: interact with external modules and code cleanup

f96eeb3

- Implemented cross-module field access and method calls to demonstrate interaction with other modules. - Cleaned codebase to fix linter errors and improve readability.

rvar-odoo force-pushed the 18.0-training-rvar branch 3 times, most recently from 5b0238d to 93657db Compare July 10, 2025 06:49

[IMP] estate: interact with external modules and code cleanup

b6e2c1e

- Implemented cross-module field access and method calls to demonstrate interaction with other modules. - Cleaned codebase to fix linter errors and improve readability.

rvar-odoo force-pushed the 18.0-training-rvar branch from 93657db to b6e2c1e Compare July 10, 2025 06:55

maad-odoo reviewed Jul 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

18.0 training rvar #848

18.0 training rvar #848

Uh oh!

rvar-odoo commented Jul 9, 2025

Uh oh!

robodoo commented Jul 9, 2025

Uh oh!

maad-odoo left a comment

Uh oh!

maad-odoo Jul 10, 2025

Uh oh!

maad-odoo Jul 10, 2025

Uh oh!

maad-odoo Jul 10, 2025

Uh oh!

maad-odoo Jul 10, 2025

Uh oh!

maad-odoo Jul 10, 2025

Uh oh!

maad-odoo Jul 10, 2025

Uh oh!

maad-odoo Jul 10, 2025

Uh oh!

maad-odoo Jul 10, 2025

Uh oh!

maad-odoo Jul 10, 2025

Uh oh!

maad-odoo Jul 10, 2025

Uh oh!

Uh oh!

		"summary": "Demo app for estate",
		"description": "This is the demo app ",


		return super().create(new_records)

		# vals_list---------> [{'partner_id': 23, 'price': 100, 'validity': 7, 'date_deadline': '2025-07-16', 'property_id': 19}]

18.0 training rvar #848

Are you sure you want to change the base?

18.0 training rvar #848

Uh oh!

Conversation

rvar-odoo commented Jul 9, 2025

Uh oh!

robodoo commented Jul 9, 2025

Uh oh!

maad-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!