[IMP] estate: interact with external modules and code cleanup

Implemented cross-module field access and method calls to demonstrate interaction with other modules.,
Cleaned codebase to fix linter errors and improve readability.

Author: kums-odoo

estate/models/estate_property.py

@@ -46,7 +46,7 @@ class EstateProperty(models.Model):
             ("sold", "Sold"),
             ("cancelled", "Cancelled"),
         ],
-        string="Status",
+        string="State",
         default="new",
         copy=False,
     )
@@ -98,16 +98,16 @@ class EstateProperty(models.Model):
     @api.depends("garden_area", "living_area")
     def _compute_total_property_area(self):
         for area in self:
-            self.total_area = self.garden_area + self.living_area
+            area.total_area = area.garden_area + area.living_area
 
     @api.depends("offer_ids.price")
     def _best_property_offer(self):
         for record in self:
             offers_list = record.mapped("offer_ids.price")
             if offers_list:
-                self.best_price = max(offers_list)
+                record.best_price = max(offers_list)
                 return
-            self.best_price = 0
+            record.best_price = 0
 
     # on change of garden status , update gardern area and its orientation
 
@@ -127,7 +127,6 @@ def action_sell_property(self):
         property_sell_status_dict = {"new": True, "sold": True, "cancelled": False}
 
         for record in self:
-            print("the object on sell action", record.read())
             if property_sell_status_dict[record.status]:
                 record.status = "sold"
                 record.state = "sold"
@@ -158,7 +157,7 @@ def _check_selling_price(self):
             if data.selling_price <= 0:
                 return
 
-            price_float_ratio = data.selling_price / self.expected_price
+            price_float_ratio = data.selling_price / data.expected_price
             ratio_diffrence = float_compare(price_float_ratio, 0.9, precision_digits=2)
             if ratio_diffrence == -1:
                 data.selling_price = 0
@@ -172,7 +171,7 @@ def _check_selling_price(self):
     @api.ondelete(at_uninstall=False)
     def _unlink_if_state_new_or_cancelled(self):
         for data in self:
-            if not bool(self.state == "new" or self.state == "cancelled"):
+            if not bool(data.state == "new" or data.state == "cancelled"):
                 raise UserError(
                     "Can't delete property which is not in new or cancelled state!"
                 )

estate/views/estate_property_tag_views.xml

@@ -8,5 +8,4 @@
         <field name="view_mode">list,form</field>
     </record>
 
-
 </odoo>

estate/views/estate_property_views.xml

@@ -106,7 +106,6 @@
                                     >
                                         <field name="price"/>
                                         <field name="partner_id"/>
-                                        <!-- <field name="status" invisible="True"/> -->
                                         <button name="action_offer_confirm" string="Accept" states="draft" type="object" icon="fa-check" 
                                            invisible="status in ('accepted','refused')"
                                         />

estate_account/__init__.py

@@ -0,0 +1 @@
+from . import models

estate_account/__manifest__.py

@@ -5,4 +5,5 @@
     "installable": True,
     "depends": ["base", "account", "estate"],
     "data": [],
+    "license": "AGPL-3",
 }

estate_account/models/__init__.py

@@ -0,0 +1 @@
+from . import estate_property

estate_account/models/estate_property.py

@@ -0,0 +1,45 @@
+from odoo import models, Command
+
+
+class EstateProperty(models.Model):
+    _inherit = "estate.property"
+
+    def action_sell_property(self):
+        for record in self:
+            partner_id = record.partner_id
+            if partner_id:
+                comission = record.selling_price * 0.06
+                adminstration_fees = 100
+
+                # creating an account move for invoicing
+                self.env["account.move"].create(
+                    {
+                        "partner_id": partner_id.id,
+                        "move_type": "out_invoice",
+                        "line_ids": [
+                            Command.create(
+                                {
+                                    "name": record.name,
+                                    "quantity": 1,
+                                    "price_unit": record.selling_price,
+                                }
+                            ),
+                            Command.create(
+                                {
+                                    "name": "Commision",
+                                    "quantity": 1,
+                                    "price_unit": comission,
+                                }
+                            ),
+                            Command.create(
+                                {
+                                    "name": "Admin Fees",
+                                    "quantity": 1,
+                                    "price_unit": adminstration_fees,
+                                }
+                            ),
+                        ],
+                    }
+                )
+
+        return super().action_sell_property()