[FIX] estate: code style fixes

- Cleaned up code to meet linting and CI style standards.

Author: kums-odoo

estate/models/estate_property.py

@@ -1,5 +1,7 @@
 from odoo import fields, models, api
 from odoo.exceptions import UserError, ValidationError
+from dateutil.relativedelta import relativedelta
+from datetime import date
 from odoo.tools.float_utils import float_compare
 
 
@@ -10,7 +12,11 @@ class EstateProperty(models.Model):
     name = fields.Char(string="Name")
     description = fields.Text(string="Description")
     postcode = fields.Text(string="Postcode")
-    date_availability = fields.Date(string="Date Availability")
+    date_availability = fields.Date(
+        string="Date Availability",
+        copy=False,
+        default=lambda self: date.today() + relativedelta(months=3),
+    )
     expected_price = fields.Float(string="Expected Price")
     selling_price = fields.Integer(string="Selling Price")
     bedrooms = fields.Integer(string="Bedrooms")
@@ -19,6 +25,7 @@ class EstateProperty(models.Model):
     garage = fields.Boolean(string="Garage")
     garden = fields.Boolean(string="Garden")
     garden_area = fields.Integer(string="Garden Area")
+
     garden_orientation = fields.Selection(
         string="Type",
         selection=[
@@ -36,9 +43,10 @@ class EstateProperty(models.Model):
             ("new", "New"),
             ("offer_received", "Offer Received "),
             ("offer_accepted", "Offer Accepted"),
-            ("Cancelled", "Cancelled"),
+            ("sold", "Sold"),
+            ("cancelled", "Cancelled"),
         ],
-        string="State",
+        string="Status",
         default="new",
         copy=False,
     )

estate/models/estate_property_offer.py

@@ -1,9 +1,4 @@
-
-
-
-
-# offers model that will offer us the offers 
-
+# offers model that will offer us the offers
 
 
 from odoo import fields, models, api
@@ -14,95 +9,106 @@
 
 
 class EstatePropertyOffer(models.Model):
-    _name = 'estate.property.offer'
-    _description = 'Offer model for the properties of real estate'
+    _name = "estate.property.offer"
+    _description = "Offer model for the properties of real estate"
     price = fields.Float()
     status = fields.Selection(
-        selection=[('accepted', 'Accepted'), ('refused', 'Refused ')],
-        string='Status',
-        copy = False
+        selection=[("accepted", "Accepted"), ("refused", "Refused ")],
+        string="Status",
+        copy=False,
     )
 
-    partner_id = fields.Many2one('res.partner', string = 'Partner')
+    partner_id = fields.Many2one("res.partner", string="Partner")
+
+    property_id = fields.Many2one("estate.property", string="Property")
 
-    property_id = fields.Many2one('estate.property', string ='Property')
+    property_type_id = fields.Many2one(
+        "estate.property.type",
+        related="property_id.property_type_id",
+        store=True,
+        readonly=False,
+    )
 
-    property_type_id = fields.Many2one("estate.property.type", related="property_id.property_type_id",store=True,readonly=False)
-    
-    validity = fields.Integer(default= 7)
+    validity = fields.Integer(default=7)
 
-    date_deadline = fields.Date(compute = '_compute_offer_deadline', inverse = '_deadline_update')
+    date_deadline = fields.Date(
+        compute="_compute_offer_deadline", inverse="_deadline_update"
+    )
 
-    
     # constrains of sql
 
-    _sql_constraints = [('check_price', 'CHECK(price > 0)', 'Offered price must be strictly positive')
+    _sql_constraints = [
+        ("check_price", "CHECK(price > 0)", "Offered price must be strictly positive")
     ]
-   
-   # order in which data is fetched
-
-    _order = "price desc"
 
+    # order in which data is fetched
 
+    _order = "price desc"
 
     # deadline will be computed based upon the validity date
-    @api.depends('validity')
+    @api.depends("validity")
     def _compute_offer_deadline(self):
         for offer in self:
             if not offer.create_date:
-                offer.date_deadline = datetime.now() + relativedelta(days=(offer.validity or 0))
+                offer.date_deadline = datetime.now() + relativedelta(
+                    days=(offer.validity or 0)
+                )
                 return
 
-        offer.date_deadline = offer.create_date + relativedelta(days=(offer.validity or 0))
-        
+        offer.date_deadline = offer.create_date + relativedelta(
+            days=(offer.validity or 0)
+        )
 
     # deadline date can also be changed and once this is saved validity will be updated
     def _deadline_update(self):
         for offer in self:
-            offer.validity = (offer.date_deadline - (offer.create_date or datetime.now()).date()).days
-       
+            offer.validity = (
+                offer.date_deadline - (offer.create_date or datetime.now()).date()
+            ).days
 
-    # action for the accepting the offer 
+    # action for the accepting the offer
     def action_offer_confirm(self):
         for record in self:
-            # since saling price is only updated when offer is accepted therefore it validates if offer 
+            # since saling price is only updated when offer is accepted therefore it validates if offer
             # is already accepted than warning
 
-           if record.property_id.selling_price > 0 :
-                raise UserError('Offer price already accepted for the property')
+            if record.property_id.selling_price > 0:
+                raise UserError("Offer price already accepted for the property")
 
-        record.status = 'accepted'
+        record.status = "accepted"
         record.property_id.selling_price = self.price
         record.property_id.partner_id = record.partner_id
-        record.property_id.state = 'offer_accepted'
+        record.property_id.state = "offer_accepted"
 
     # action for the refusal of the status
     def action_offer_refuse(self):
-
         for record in self:
-            if (record.status == 'accepted'): 
+            if record.status == "accepted":
                 record.property_id.selling_price = 0
-                record.property_id.partner_id = ''
-            record.status = 'refused'
+                record.property_id.partner_id = ""
+            record.status = "refused"
 
-
-    
     # now in case of offer creation CRUD
-    # self will be a proxy object , 
-    # property_id feilds is available in vals 
+    # self will be a proxy object ,
+    # property_id feilds is available in vals
     @api.model_create_multi
     def create(self, vals):
-
         # will check the offer value and does property has other offers which are max thw\an this one
-        for value in vals: 
-            property_details = self.env['estate.property'].browse(value.get('property_id'))
+        for value in vals:
+            property_details = self.env["estate.property"].browse(
+                value.get("property_id")
+            )
             for property_data in property_details:
                 offers_list = property_data.mapped("offer_ids.price")
                 max_offer = max(offers_list, default=0)
-                comparison_result = float_compare(value.get('price'),max_offer, precision_digits=2)
-                
-                if comparison_result == -1 :
-                    raise UserError('Offer with a lower amount than an existing offer')
+                comparison_result = float_compare(
+                    value.get("price"), max_offer, precision_digits=2
+                )
+
+                if comparison_result == -1:
+                    raise UserError("Offer with a lower amount than an existing offer")
+
+                if property_data.state == "new":
+                    property_data.state = "offer_received"
 
         return super().create(vals)
-       

estate/models/estate_property_tag.py

@@ -1,19 +1,15 @@
-
-
 # the tag model will be here
 
 
-
 from odoo import fields, models
 
 
-
 class EstatePropertyTag(models.Model):
     _name = "estate.property.tag"
     _description = "Tag model for the estate properties"
     name = fields.Char(required=True)
     color = fields.Integer(default=1)
-    _sql_constraints = [('check_uniquness', ' UNIQUE(name)', 'Tag name must be unique')]
+    _sql_constraints = [("check_uniquness", " UNIQUE(name)", "Tag name must be unique")]
 
     # order on which data will be fetched
     _order = "name desc"

estate/models/estate_property_type.py

@@ -1,33 +1,33 @@
 from odoo import fields, models, api
 
-# Property type model for properties 
+
+# Property type model for properties
 # prpoerties can be of type house, penthouse, etc.
 class EstatePropertyType(models.Model):
-      _name = "estate.property.type"
-      _description = "Type of properties of estate model"
-      name = fields.Char(required=True)
-
-      property_ids = fields.One2many('estate.property', 'property_type_id')
-
-      offer_ids = fields.One2many("estate.property.offer", "property_type_id", "Offer For Property Type")
-
-      offer_count = fields.Integer(compute = "_compute_offer_count")
-      sequence = fields.Integer('Sequence', default=1)
-
-      # sql constrains :::
+    _name = "estate.property.type"
+    _description = "Type of properties of estate model"
+    name = fields.Char(required=True)
 
-      _sql_constraints = [('check_uniquness', ' UNIQUE(name)', 'Type of property name must be unique')]
+    property_ids = fields.One2many("estate.property", "property_type_id")
 
-      # order on which data will be fetched
+    offer_ids = fields.One2many(
+        "estate.property.offer", "property_type_id", "Offer For Property Type"
+    )
 
-      _order = "sequence, name desc"
+    offer_count = fields.Integer(compute="_compute_offer_count")
+    sequence = fields.Integer("Sequence", default=1)
 
+    # sql constrains :::
 
-      @api.depends("offer_ids")
+    _sql_constraints = [
+        ("check_uniquness", " UNIQUE(name)", "Type of property name must be unique")
+    ]
 
-      def _compute_offer_count(self):
-            for data in self:
-                  data.offer_count = len(data.offer_ids)
-         
+    # order on which data will be fetched
 
+    _order = "sequence, name desc"
 
+    @api.depends("offer_ids")
+    def _compute_offer_count(self):
+        for data in self:
+            data.offer_count = len(data.offer_ids)

estate/models/inherited_res_users.py

@@ -1,12 +1,13 @@
-
-
-# This model inherits from res.users model 
+# This model inherits from res.users model
 
 from odoo import models, fields
 
+
 class InheritedResUsers(models.Model):
-    _inherit = 'res.users'
-    property_ids = fields.One2many('estate.property', 'user_id', "Estate Property",
-        domain=[('state', 'in', ['new','offer_received'])]
+    _inherit = "res.users"
+    property_ids = fields.One2many(
+        "estate.property",
+        "user_id",
+        "Estate Property",
+        domain=[("state", "in", ["new", "offer_received"])],
     )
-

estate_account/__manifest__.py

@@ -1,10 +1,8 @@
 {
-    'name': 'Real Estate Invoicing',
-    'category': 'All',
-    'application': True,
-    'installable': True,
-    'depends' : ['base','account', 'estate'],
-    'data': [
-        
-        ]
-}
+    "name": "Real Estate Invoicing",
+    "category": "All",
+    "application": True,
+    "installable": True,
+    "depends": ["base", "account", "estate"],
+    "data": [],
+}