Skip to content

[IMP] runbot: add warning on some config_views #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

Xavier-Do
Copy link
Contributor

The warning will appear on build (and children)
This is useful to explain the purpose of the build and special attention to give when reading the result. (templates)

the warning will appear on build
This is useful to explain the purpose of the build and special
attention to give when reading the result. (templates)
@C3POdoo C3POdoo requested a review from a team March 10, 2025 14:39
Copy link
Contributor

@Williambraecky Williambraecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The color and the text being center makes it feel like something is wrong with the build.

That being said, I don't have an alternative for you, so lgtm.

@Xavier-Do
Copy link
Contributor Author

The goal is to get user attention but I could display that in info if the build is in success (or not display it at all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants