[IMP] use relative addresses to self in links#90
Conversation
odony
force-pushed
the
master
branch
7 times, most recently
from
ab648fe to
9bd4838
Compare
| <li><a t-attf-href="/runbot/build/{{bu['id']}}">Logs <i class="fa fa-file-text-o"/></a></li> | ||
| <li t-if="bu['host']"><a t-attf-href="http://{{bu['host']}}/runbot/static/build/#{bu['real_dest']}/logs/job_10_test_base.txt">Full base logs <i class="fa fa-file-text-o"/></a></li> | ||
| <li t-if="bu['host']"><a t-attf-href="http://{{bu['host']}}/runbot/static/build/#{bu['real_dest']}/logs/job_20_test_all.txt">Full all logs <i class="fa fa-file-text-o"/></a></li> | ||
| <li t-if="bu['host']"><a t-attf-href="/runbot/static/build/#{bu['real_dest']}/logs/job_10_test_base.txt">Full base logs <i class="fa fa-file-text-o"/></a></li> |
There was a problem hiding this comment.
Was there a reasoning behind only using the path in the href? IMO this and the below few hrefs should use the protocol relative domain as well, like the above ones.
//{{bu['domain']}}/runbot/static/build/#{bu['real_dest']}/logs/job_10_test_base.txt
There was a problem hiding this comment.
the reasoning was that this is a link to runbot's frontend, and depending on your configuration, bu['host'] gives you the wrong value: https://github.com/odoo/odoo-extra/blob/master/runbot/runbot.py#L1068 - this is needed for load balancing (I guess), but here, the link must go to the frontend. I think this is a generic issue that doesn't bite much more people because the fqdn coincides with the frontend domain name very often.
There was a problem hiding this comment.
Ah this makes sense, thanks for the elaboration @hbrunn
|
👍 |
2 participants
No description provided.