Skip to content

[FIX] GridComposer: Recompute composer position if we change edited cell #6625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

rrahir
Copy link
Collaborator

@rrahir rrahir commented Jun 19, 2025

Currently, the gridComposer position is not recomputed if we start editing another cell, that is, if we decide to manipulate the composerStore outside of a standard flow where the edition state is reset when changing editing cells.

Task: 4879186

Description:

description of this task, what is implemented and why it is implemented that way.

Task: 4879186

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Jun 19, 2025

Pull request status dashboard

Currently, the gridComposer position is not recomputed if we start
editing another cell, that is, if we decide to manipulate the
composerStore outside of a standard flow where the edition state is
reset when changing editing cells.

Task: 4879186
@rrahir rrahir force-pushed the 18.0-grid-composer-recompute-poisition-rar branch from 9159a72 to ef6e604 Compare June 20, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants