Skip to content

[IMP] account: rename batch payment sequence to PAY/year format #4810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0-rd-accounting-onboarding-malb
Choose a base branch
from

Conversation

shzi-odoo
Copy link

Renamed the field on the company model to use a
new prefix format instead of , to better reflect its purpose for identifying payment groups.

Updated corresponding test files to align with the new sequence format.

Also adjusted group permissions on the accounting analytics-related menu items to restrict access only when the feature is enabled, improving the clarity of the UI.

Renamed the field  on the company model to use a
new prefix format  instead of , to better reflect its
purpose for identifying payment groups.

Updated corresponding test files to align with the new sequence format.

Also adjusted group permissions on the accounting analytics-related menu
items to restrict access only when the feature is enabled, improving the
clarity of the UI.
@robodoo
Copy link

robodoo commented Jul 3, 2025

This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged.

Copy link

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks good but there is one change that should not be there 👀

@@ -32,7 +32,7 @@
<menuitem id="account_reports_partners_reports_menu" name="Partner Reports" sequence="3"/>
<menuitem id="account_reports_management_menu" name="Management" sequence="4">
<menuitem id="menu_action_account_invoice_report_all" name="Invoice Analysis" action="action_account_invoice_report_all" sequence="1"/>
<menuitem id="menu_action_analytic_reporting" name="Analytic Report" action="action_analytic_reporting" groups="account.group_account_readonly"/>
<menuitem id="menu_action_analytic_reporting" name="Analytic Report" action="action_analytic_reporting" groups="analytic.group_analytic_accounting"/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change should not be in this task though 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants