Merging onboarding level 1 tasks #4809
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shzi-odoo
commented
Jul 3, 2025
shzi-odoo
commented
- Created a new field in the company to separately track the PAY sequence Id's instead of batch Id's
- Created a new function to get the next available ID
- Changed the group of the menu items related to accounting analytics if not activated
- Inside payment registery file I set the new lable of communication field which is shown at the memo to be with the new payment group Id's
…eld for group payments to use in group payment memo
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
reviewed
Jul 3, 2025
| @@ -49,3 +49,5 @@ package.json | |||
| /man/ | |||
| /share/ | |||
| /src/ | |||
|
|
|||
| venv/ | |||
| @@ -167,6 +167,20 @@ class ResCompany(models.Model): | |||
| 'prefix': 'BATCH/%(year)s/', | |||
There was a problem hiding this comment.
the solution would be to change the BATCH to -> PAY and modify the test accordingly
| use group_payment_sequence_id to get it (eventually create it first): e.g PAY/2025/00001 | ||
| ''' | ||
| self.ensure_one() | ||
| return self.sudo().group_payment_sequence_id.next_by_id() |
There was a problem hiding this comment.
no need for that if the field is gone 😄
|
Also commit message should follow those guidelines 😄 |
|
i will close this since it's a merge of multiple task, we will say it's the one for the group of analytic 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.