[base:runtime] fix print_i64 using an OOB index when min(i64) is given.
#6024
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blob1807
changed the title
base:runtime] fix print_i64 uses an OOB index when min(i64) is given.base:runtime] fix print_i64 using an OOB index when min(i64) is given.
gingerBill
reviewed
Dec 15, 2025
Comment on lines
+187
to
+188
| b :: u64(10) | ||
| u := x |
Member
There was a problem hiding this comment.
Any reason this was changed too?
Contributor
Author
There was a problem hiding this comment.
As already stated, To a have consistent look between the two is all. There's no reason beyond that.
I do understand random formatting changes are weird to do. So I can revert it if you wish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6018 by wrapping the
absin a cast. As by itselfabs(min(T)) == min(T). This also mirrors howcore:strconvdoes it.See linked issue for more information.
This PR also does some minor formatting to
print_u64to keep it consistent withprint_i64.