fix: improve error handling and add debug logs for token fetching #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
need a rebase |
imjasonh
reviewed
Oct 14, 2025
| console.log(`::add-mask::${encode(msg)}`); | ||
| } | ||
|
|
||
| export function parseOIDC(token) { |
Collaborator
There was a problem hiding this comment.
I'm slightly worried about parsing the OIDC here, and not verifying it. I also don't hugely want to add verification to this code, and instead just forward it to the service which will validate it.
Was this only added so that we could log the OIDC subject? I wonder if there's a better way to do that. It's a very nice trait of this codebase that it's simple and "small enough to fit in your head".
Author
There was a problem hiding this comment.
I just wanted to output the subject for easier debugging :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was pretty lost why I don't get a token. I added further debugging for my next WHY IS THIS NOT WORKING. btw it was cache, it's always cache