You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At a cursory glance this looks good.
Unfortunately, however cool this is, I am unable to take on maintenance for a fringe-use-case backend.
I suggest you host this on its own repository, e.g. dakotath/imgui_impl_gx, just the two files + README, and I will happily sadd suitable links from wiki and other places.
Also as per #9400, I am open to discussing how to avoid ABGR/RGBA conversion, which you may be able to avoid entirely by defining IM_COL32_R_SHIFT, IM_COL32_G_SHIFT, IM_COL32_B_SHIFT, IM_COL32_A_SHIFT, IM_COL32_A_MASK if deemed useful. But I would guess the current backend it's only used for infrequent texture updates and probably.
I was surprised by using an immediate mode graphics API aka GX_Begin(), GX_Position3f32() etc. instead of a full buffer copy but it seems like it is what maps to the HW for uploads, as per https://github.com/devkitPro/libogc/blob/959871c08ed80d1a63b258bc207218623ea1b0e5/gc/ogc/gx.h#L2122.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Nintendo Wii/GC rendering backend for use with Wii/GC homebrew development.