-
Notifications
You must be signed in to change notification settings - Fork 352
add Topiary to “Formatting Your Code” #3097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
96968a0
to
9819bc3
Compare
You've changed the URL of the page, so you'll need to add some redirect from the old one. |
9819bc3
to
d7fe9ec
Compare
You've changed the URL of the page, so you'll need to add some
redirect from the old one.
I don’t think this is true. The Markdown YAML heading thing’s id value
has not changed. However, the filename (& title) should change as it
doesn’t reflect that id (& by proxy the URL slug) as well as the
sidebar’s “Formatting your Code” — else you don’t want to give the wrong
impression that there is just one formatter.
|
8218789
to
37591b4
Compare
fixes some CI linter
37591b4
to
bed1873
Compare
My bad. I saw the filename change and at first I assume that the slug was changed to match it. |
bed1873
to
e2c017b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imho, the OCaml website should document how to use the tools of the OCaml Platform. It's OK to provide a link to other resources like eg Topiary for formatting and Nix for package management, but as I understand it the goal of this site is not to provide documentation on those alternatives.
If that is the case, then how to get something listed as “Tools with a status of "active" or "sustain" are considered stable and mature”? This has been a stable project that does things other the other formatters do not. |
I think that is a separate question for discussion in the forum. |
Waiting input from discuss.ocaml.org on this. |
I think the question of what exactly the OCaml.org website should present here is open for interpretation and a good topic for a community discussion on https://discuss.ocaml.org. I don't think we have a clear policy here yet. Do you want me to open a discussion? Obviously, documenting the OCaml Platform Tools is a main goal, but I could see having every tooling-focused document have a section at the end listing alternatives (only projects that are production ready and stable).
We have a description of what it takes to become an OCaml Platform Tool here: https://ocaml.org/policies/governance#iv-ocaml-platform |
How about we mention Topiary as an alternative at the end of the formatting tutorial and link to a Cookbook Recipe for it? I want to avoid adding too much detail about alternatives to the tutorials as per ocaml.org/DOCUMENTATION_WRITING.md Line 42 in c75be9b
|
The documentation could also be stripped down. While there are defaults (no need for a blank |
Is there a good place where we could put this so ocaml.org can link to it? |
I recommend making it a Cookbook Recipe: https://ocaml.org/cookbook |
Topiary is a viable code formatter for OCaml projects. My favorite feature compared to its competitor is that Topiary can be configured to use tab indentation for user accessibility (which affects me). While Topiary can be configured, it isn’t as intuitive to configure as many other code formatters that just look for a specific file in a specific location.
Additionally, I removed the implicit assumptions of OCamlFormat in the description & title since the sidebar & URL slug generically state “Formatting Your Code” without specifying a tool. This also required moving the file whose name implied OCamlFormat.
It would have been nice to use a callout/admonition for the “TIP:”, but Markdown does not support this feature.
1
Footnotes
Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute. ↩