Skip to content

Remove monorepo benchmark #11930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Leonidas-from-XIV
Copy link
Collaborator

In the latest dune-dev meeting we agreed that the Monorepo benchmark is obsolete and takes a long time, thus it is reasonable to remove it.

Along with this PR, it would probably make sense to archive this repo to make it read-only and signal it is not in use anymore: https://github.com/ocaml-dune/ocaml-monorepo-benchmark however I do not have the required permissions to do so.

@Leonidas-from-XIV Leonidas-from-XIV added the chore Something that just needs to be done. label Jun 19, 2025
Copy link
Collaborator

@maiste maiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might require some actions from someone with admin privileges to remove the Benchmark app.

In the dune-dev meeting on the 11th of June 205 we agreed that the
monorepo benchmark has served its purpose and is obsolete now. As it
takes a long time, it is reasonable to remove it.

Signed-off-by: Marek Kubica <[email protected]>
@Leonidas-from-XIV
Copy link
Collaborator Author

I've talked with @punchagan who disabled the CI check. Pushed this branch to confirm and yes, it does not get built anymore as far as I see.

@Leonidas-from-XIV Leonidas-from-XIV merged commit 55353da into ocaml:main Jun 20, 2025
23 of 24 checks passed
@Leonidas-from-XIV Leonidas-from-XIV deleted the remove-monorepo-bench branch June 20, 2025 13:29
@gridbugs
Copy link
Collaborator

Heads up I have archived https://github.com/ocaml-dune/ocaml-monorepo-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that just needs to be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants