Add batched copy for regular and block device files#748
Open
koonwen wants to merge 1 commit intoocaml-multicore:mainfrom
Open
Add batched copy for regular and block device files#748koonwen wants to merge 1 commit intoocaml-multicore:mainfrom
koonwen wants to merge 1 commit intoocaml-multicore:mainfrom
Conversation
talex5
reviewed
Aug 23, 2024
Collaborator
talex5
left a comment
There was a problem hiding this comment.
Thanks for investigating this!
Doing this in Flow.copy might be a problem, because normally it copies bytes in order but this doesn't. For example, if I'm doing tail -f dst then I might miss some parts of the file. But having an Eio.Path.copy that worked this way would be reasonable.
Also, it shouldn't rely on fixed buffers as they're not always available (this is why the benchmarks are failing). I'm not convinced they're any faster either (Anil said they only make a difference for networking, and rarely even then, I think).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default behavior of
Flow.copyin the uring backend doesn't leverage batching syscalls to be sent in one shot. In principle, files that are bounded in size can use this batched submission pattern to reduce context switching overhead. The batched copy implementation is taken directly fromlib_eio_linux/tests/eurcp.ml.Old behaviour:

New behaviour:

Tests: