Open
Conversation
polytypic
commented
Jul 21, 2023
polytypic
commented
Jul 21, 2023
polytypic
force-pushed
the
fix-mdx-tests-to-run-on-windows
branch
from
502d91d to
ad9e39c
Compare
polytypic
commented
Jul 21, 2023
|
|
||
| <!-- $MDX skip --> | ||
| ```ocaml | ||
| # Eio_main.run @@ fun env -> |
Contributor
Author
There was a problem hiding this comment.
For some reason this test never completes. So, I disabled it.
Collaborator
There was a problem hiding this comment.
That seems worrying! Is it only an MDX thing, or does the example in examples/net also hang if the server side isn't running?
polytypic
changed the title
polytypic
force-pushed
the
fix-mdx-tests-to-run-on-windows
branch
5 times, most recently
from
56d9fe9 to
cfbb46b
Compare
polytypic
commented
Jul 24, 2023
polytypic
force-pushed
the
fix-mdx-tests-to-run-on-windows
branch
from
cfbb46b to
988e85a
Compare
polytypic
commented
Jul 24, 2023
| @@ -904,6 +912,7 @@ ONE TWO THREE | |||
| If you want to capture the output of a process, you can provide a suitable `Eio.Flow.sink` as the `stdout` argument, | |||
Contributor
Author
There was a problem hiding this comment.
I disabled the process tests. There are two problems:
- Process operations are not yet implemented on Windows.
- Even if the process operations were implemented on Windows, the tests would not work on Windows, because they use commands that do not necessarily exist on Windows.
Collaborator
There was a problem hiding this comment.
Yeah. We really need a way to selectively disable tests on different platforms (e.g. realworldocaml/mdx#393).
Contributor
Author
|
We could consider adding some TODO notes to things disabled in this PR currently, merge it — so we'd have more Windows tests running on CI — and then continue with the TODOs in separate PRs. Or we can continue work in this PR and not merge it yet. Either way is fine with me. |
polytypic
force-pushed
the
fix-mdx-tests-to-run-on-windows
branch
2 times, most recently
from
dde2046 to
5cca345
Compare
polytypic
force-pushed
the
fix-mdx-tests-to-run-on-windows
branch
from
5cca345 to
2b8cded
Compare
polytypic
force-pushed
the
fix-mdx-tests-to-run-on-windows
branch
from
2b8cded to
9b86081
Compare
polytypic
force-pushed
the
fix-mdx-tests-to-run-on-windows
branch
from
9b86081 to
a383832
Compare
polytypic
force-pushed
the
fix-mdx-tests-to-run-on-windows
branch
2 times, most recently
from
5897e55 to
65a4936
Compare
polytypic
force-pushed
the
fix-mdx-tests-to-run-on-windows
branch
from
65a4936 to
8ce161d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.