Add js_of_ocaml alpha #352
Conversation
| opam pin add -n --yes --switch $* base.v0.14.3 https://github.com/janestreet/base.git#v0.14.3 | ||
| opam pin add -n --yes --switch $* coq-core https://github.com/ejgallego/coq/archive/refs/tags/multicore-2021-09-29.tar.gz | ||
| opam pin add -n --yes --switch $* coq-stdlib https://github.com/ejgallego/coq/archive/refs/tags/multicore-2021-09-29.tar.gz | ||
| opam pin add -n --yes --switch $* dune https://github.com/dra27/dune/archive/2.9.3-5.0.0.tar.gz |
There was a problem hiding this comment.
Sandmark has been updated to build with dune-2.9.3-5.0.0 and ocamlfind.1.9.3.git. Kindly pull the latest changes from the -main branch.
There was a problem hiding this comment.
I still have to pin dune to the appropriate repo, right?
There was a problem hiding this comment.
Yes. I have added the instructions in the README at https://github.com/ocaml-bench/sandmark/blob/main/README.md?plain=1#L24.
| ] | ||
| dev-repo: "git+https://github.com/ocaml/num.git" | ||
| url { | ||
| src: "https://github.com/ocaml/num/archive/v1.4.tar.gz" |
There was a problem hiding this comment.
Please avoid adding manual dependencies to Sandmark. num.1.3is already specified in dev.opam at https://github.com/ocaml-bench/sandmark/blob/main/dependencies/template/dev.opam#L42. It is recommended to add dependencies only to dev.opam. The dependencies/packages folder is for packages with custom patches.
|
Sandmark has been updated to build for 5.1.0+trunk. @ElectreAAS Please review the conflicting files in order to build js_of_ocaml with Sandmark. |
|
sandmark has moved to 5.1.0+trunk, we probably need a new version of js_of_ocaml that doesn't conflict with that |
3 participants
This is a draft PR that's related to #18. Certain packages were pinned to the
Makefiledue to the incompatibility of Sandmark with the alpha repo at the time of writing this. The build currently fails due to some conflicts that occur withjs_of_ocamlwithin the Sandmark universe.