Skip to content

Conversation

@Warchamp7
Copy link
Member

Description

Fixes the transitions duration spinbox to be properly updated when loading data.

Motivation and Context

When a scene collection is loaded, it contains information about the default transition and it's duration. This value was being loaded into transitionDuration and used but because it wasn't using the setter method, the spinbox was not getting updated.

How Has This Been Tested?

Loaded OBS, swapped scene collections.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Warchamp7 Warchamp7 force-pushed the transitions-initial-value branch from 313d072 to 58dcf0c Compare December 9, 2025 18:41
@RytoEX
Copy link
Member

RytoEX commented Dec 10, 2025

Do you know what commit broke this?

@RytoEX RytoEX added the Bug Fix Non-breaking change which fixes an issue label Dec 10, 2025
@RytoEX RytoEX requested review from PatTheMav and RytoEX December 10, 2025 18:25
@Warchamp7
Copy link
Member Author

Do you know what commit broke this?

ffcc3ac

@RytoEX RytoEX requested a review from tytan652 December 10, 2025 18:29
@RytoEX
Copy link
Member

RytoEX commented Dec 10, 2025

Do you know what commit broke this?

ffcc3ac

cc @tytan652

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

Copy link
Collaborator

@tytan652 tytan652 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@RytoEX RytoEX self-assigned this Dec 10, 2025
@RytoEX RytoEX added this to the OBS Studio 32.0 milestone Dec 10, 2025
@RytoEX RytoEX merged commit ff9b4eb into obsproject:master Dec 12, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Non-breaking change which fixes an issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants