Skip to content

Conversation

prgmitchell
Copy link
Member

@prgmitchell prgmitchell commented Jul 18, 2025

Description

Fix false negatives by only checking the bitrate that is immediately after the service recommendations.

Motivation and Context

Noticed some issues with logs posted in the OBS discord server. After fixing/testing I noticed that #184 was submitted. When running my test logs against that PR I found some issues, for example https://obsproject.com/logs/3zpBZBLcluZG6A3Q throws an error. Rather than trying to leave feedback on that and troubleshoot I just decided to submit this PR since it was already complete.

How Has This Been Tested?

https://obsproject.com/logs/3zpBZBLcluZG6A3Q
https://obsproject.com/logs/fHq5sThsbyvP8D4K
https://obsproject.com/logs/3MlQSpcBSLAXzWY1
https://obsproject.com/logs/JzJXZKQf9pljFOOL

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Fix false negatives by only checking the bitrate that is immediately
after the service recommendations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant