feat: Add optional image preloading before clipping #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurlez
commented
Nov 12, 2025
kurlez
commented
- Add 'Add to Obsidian with Loading Images' option in dropdown menu
- Implement page scrolling to preload images before clipping
- Show loading indicator on page and in popup during image loading
- Use proper event listeners to avoid overwriting existing image handlers
- Add Images icon to icons.ts for the new menu option
- Add i18n support for 'loadingImages' and 'addToObsidianWithLoadingImages'
- Default behavior remains unchanged (no preloading by default)
- Add 'Add to Obsidian with Loading Images' option in dropdown menu - Implement page scrolling to preload images before clipping - Show loading indicator on page and in popup during image loading - Use proper event listeners to avoid overwriting existing image handlers - Add Images icon to icons.ts for the new menu option - Add i18n support for 'loadingImages' and 'addToObsidianWithLoadingImages' - Default behavior remains unchanged (no preloading by default)
Author
|
This is extremely helpful. When I clip webpages with many images, Obsidian often fails to load them afterward. With this feature, image-loading failures are greatly reduced. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.