ci: run the test suite under the race detector (PIPE-1223) - #272
Open
Dylan-M wants to merge 1 commit into
Open
Conversation
…PE-1223) Assisted-by: Claude Opus 4.8
This was referenced Aug 3, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Proposed Change
CI ran
go test ./...with no-race, so data races in production code passed silently. This adds amake test-racetarget (go test -race ./...) and points the CI test job at it, withCGO_ENABLED=1because the race detector needs cgo.make teststays unchanged for fast local runs.The suite passes under
-race; the data races it would otherwise catch are fixed in this stack.How to validate
make test-raceruns the full suite under-raceand passes (52 packages, no race reports).make test-racelocally, or review the workflow change.Checklist