Skip to content

ci: run the test suite under the race detector (PIPE-1223) - #272

Open
Dylan-M wants to merge 1 commit into
dylanmyers/pipe-1230-tcp-udp-stop-drainfrom
dylanmyers/pipe-1223-race-in-ci
Open

ci: run the test suite under the race detector (PIPE-1223)#272
Dylan-M wants to merge 1 commit into
dylanmyers/pipe-1230-tcp-udp-stop-drainfrom
dylanmyers/pipe-1223-race-in-ci

Conversation

@Dylan-M

@Dylan-M Dylan-M commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Proposed Change

CI ran go test ./... with no -race, so data races in production code passed silently. This adds a make test-race target (go test -race ./...) and points the CI test job at it, with CGO_ENABLED=1 because the race detector needs cgo. make test stays unchanged for fast local runs.

The suite passes under -race; the data races it would otherwise catch are fixed in this stack.

How to validate
  • Automated: make test-race runs the full suite under -race and passes (52 packages, no race reports).
  • Manual: run make test-race locally, or review the workflow change.
Checklist
  • Changes are tested
  • CI has passed

Dylan-M commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dylan-M Dylan-M changed the title ci: run the test suite under the race detector via make test-race (PIPE-1223) ci: run the test suite under the race detector (PIPE-1223) Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant