Skip to content

remove ViewPropTypes #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samuelpbowman
Copy link

@samuelpbowman samuelpbowman commented Nov 9, 2021

Removed references to ViewPropTypes, a deprecated type from the react-native package. The new setup should allow for web support, as react-native-web hasn't supported ViewPropTypes since its version 0.12 (now on 0.17.5).

Should fix #37

@gkpo
Copy link

gkpo commented May 4, 2022

Can we merge this ? I also have the warning.... seems like the package hasn't been maintained for a while...

@cameronnapoli
Copy link

+1

anoukhello added a commit to pass-culture/pass-culture-app-native that referenced this pull request May 24, 2022
…nore for test warning

	Add a log ignore for this warning:
	"ViewPropTypes will be removed from React Native. Migrate to ViewPropTypes exported from'deprecated-react-native-prop-types'"
	This warning comes from modules react-native-dash and react-native-date-picker that still use ViewPropTypes.
	We'll be able to remove this log ignore once react-native-dash have remove references to ViewPropTypes
 	(obipawan/react-native-dash#36) and once we bump react-native-date-picker to 4.2.2 version
anoukhello added a commit to pass-culture/pass-culture-app-native that referenced this pull request May 27, 2022
…nore for test warning

	Add a log ignore for this warning:
	"ViewPropTypes will be removed from React Native. Migrate to ViewPropTypes exported from'deprecated-react-native-prop-types'"
	This warning comes from modules react-native-dash and react-native-date-picker that still use ViewPropTypes.
	We'll be able to remove this log ignore once react-native-dash have remove references to ViewPropTypes
 	(obipawan/react-native-dash#36) and once we bump react-native-date-picker to 4.2.2 version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web support?
4 participants