chore: change version comparison logic in RustdocGenerator #1293
+71
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frank-III
force-pushed
the
check-version-without-metadata
branch
from
2f54609 to
5133ff6
Compare
obi1kenobi
reviewed
Jun 13, 2025
Owner
obi1kenobi
left a comment
obi1kenobi
left a comment
There was a problem hiding this comment.
The change looks great!
Would you be able to add a test for it? For example, a GitHub Actions workflow that checks out the project that found this issue, reproduces the original invocation that used to fail, and ensures it succeeds? There should be a few examples of similar uses of other projects that you should be able to follow.
Frank-III
force-pushed
the
check-version-without-metadata
branch
from
41b1c84 to
8edd3be
Compare
Owner
|
I noticed the test is being stubborn and hard to get working. If it's not coming together, feel free to ping the OP in the related issue — I'm sure they'd know what to do. |
Frank-III
force-pushed
the
check-version-without-metadata
branch
from
b0f0bbf to
d2b9759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #1262