ci: run pylint on ci build #1095
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logging warn is deprecated since python 3.3 update it to warning instead. Signed-off-by: Jasper Berton <[email protected]>
When opening files it is advised by pylint to enforce a certain encoding. Signed-off-by: Jasper Berton <[email protected]>
These prefixes were necessary in Python 2 to indicate a string was Unicode, but since Python 3.0 strings are Unicode by default. Signed-off-by: Jasper Berton <[email protected]>
When throwing errors from another error, re-raise the error where it originated from. Signed-off-by: Jasper Berton <[email protected]>
- fixed attributes that don't conform to snake_case naming style - assured attributes are initialized in the __init__ phase - assured attributes are created before usage Signed-off-by: Jasper Berton <[email protected]>
Wrong constants were used to import certain os path. Signed-off-by: Jasper Berton <[email protected]>
update missing and additional whitespace and group imports above. Signed-off-by: Jasper Berton <[email protected]>
context check hostname is a true or false value, it does not hold functions. Signed-off-by: Jasper Berton <[email protected]>
import has issue detecting the default config values from the new config values used per package. Update naming so distinction is possible. Signed-off-by: Jasper Berton <[email protected]>
simplify constant to not use class property to avoid triggering pylint. Signed-off-by: Jasper Berton <[email protected]>
config was called without a fqdn value which caused linter to throw. Signed-off-by: Jasper Berton <[email protected]>
use more specific name for db python file to avoid confusion on import statement. Signed-off-by: Jasper Berton <[email protected]>
Fix multiple issues with python files highlighted by python-check by already configured python linting modules. Signed-off-by: Jasper Berton <[email protected]>
After the build is completed and all python files are generated, run python check. Python check runs pylint, pyflakes, isort and pycodestyle. This ensures a proper and uniform layout of python files. Signed-off-by: Jasper Berton <[email protected]>
JasperB-TeamBlue
requested review from
ahadas,
bennyz,
didib,
emesika,
michalskrivanek,
sandrobonazzola,
sgratch and
smelamud
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
Implemented pylint to check each python file for possible errors.
Cleaned up errors and other small groups of pylinting complaints.
Added installment of certain packages in ci so that pylint does not complain on missing packages.
Are you the owner of the code you are sending in, or do you have permission of the owner?
[y]