Auto migrate p12 files with legacy encryption #1090
Merged
+150
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-boden
requested review from
ahadas,
bennyz,
didib,
emesika,
michalskrivanek,
sandrobonazzola,
sgratch and
smelamud
as code owners
peter-boden
requested review from
JasperB-TeamBlue and
dupondje
and removed request for
ahadas,
bennyz,
didib,
emesika,
michalskrivanek,
sandrobonazzola,
sgratch and
smelamud
Member
|
/ost |
|
⏳ Running ost suite 'basic-suite-master' on distro 'el9stream'. Follow the progress here. |
|
😭💔 ost suite 'basic-suite-master' on distro 'el9stream' failed. (details) |
Member
|
/ost |
|
⏳ Running ost suite 'basic-suite-master' on distro 'el9stream'. Follow the progress here. |
|
😭💔 ost suite 'basic-suite-master' on distro 'el9stream' failed. (details) |
First check that the needed db user is configured/present and only then look at the change_db flags. Signed-off-by: Peter Boden <[email protected]>
dupondje
force-pushed
the
fix/upgrade_certs
branch
from
5158150 to
2ed5902
Compare
Add the concept of an install root to the engine-backup. On a regular production system the install root is `/`, but on development systems this root (i.e. installed from an rpm) can be anything. This makes it so that taking and restoring backups of development systems is impossible. There already was a devmode flag, if this flag is set to 1 then the INSTALL_ROOT will be equal to `$PREFIX/`, in all other cases the root will be `/` (like it was before). Also, use the 'ENGINE_USR' var where a hardcoded path was used. A backup that you take is now agnostic of the path where ovirt was/is installed. So you can restore a production backup on a dev box and vice versa. Signed-off-by: Peter Boden <[email protected]>
peter-boden
force-pushed
the
fix/upgrade_certs
branch
from
2ed5902 to
a883f53
Compare
Member
Author
|
/ost |
|
⏳ Running ost suite 'basic-suite-master' on distro 'el9stream'. Follow the progress here. |
|
😎💪 ost suite 'basic-suite-master' on distro 'el9stream' finished successfully. (details) |
dupondje
reviewed
Oct 29, 2025
packaging/bin/engine-backup.sh.in
Outdated
| local pki_password="$2" | ||
| local timestamp="$3" | ||
|
|
||
| log "Found legacy encryption in ${file}, re-encrypting to AES-256" |
Member
There was a problem hiding this comment.
As we don't force AES-256, perhaps strip that from the output?
When restoring a backup from CentOS 8 onto a CentOS 9 system, the p12 files that were generated are invalid, because they use a legacy encryption on CentOS 9. So, upon restore, we try to read the p12 files. When this fails we try to read the p12 file with the `legacy` flag. If this succeeds, we re-encrypt the p12 file with a newer encryption algorythm. The old p12 files is backup up. We log all actions so that the user knows what happened, and can act upon errors. Signed-off-by: Peter Boden <[email protected]>
The `-aes256` flag is ignored by `openssl pkcs12 export`. We remove it and fall back to the default, which we assume is secure enough, and will stay more up-to-date while algorythms evolve. Signed-off-by: Peter Boden <[email protected]>
peter-boden
force-pushed
the
fix/upgrade_certs
branch
from
a883f53 to
31283a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
This is the improved version of #1072 , which can probably be closed now.
And this also makes #932 obsolete.
Are you the owner of the code you are sending in, or do you have permission of the owner?
y