fix user permission href missing from certain resources #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raaghav Wadhawan <[email protected]>
dupondje
requested changes
Jul 4, 2025
Member
dupondje
left a comment
dupondje
left a comment
There was a problem hiding this comment.
This feels like a hack to get to the correct result?
Could you explain a bit more (with examples) what it changes, and why you changed it in this place.
Cause why is the suggestedParentType there otherwise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
OLVM REST API responses for certain resource permissions including: cpuprofiles, vnicprofiles, and diskprofiles, were missing href(s) for a given resource id
Changes introduced with this PR
A change to the REST API forces all calls, to the REST API, for resource permissions to follow the same format. Changing the
suggestedParentTypetoUser.classchanges the response for all resources to follow the patternusers/USER_ID/permissions/PERMISSION_IDAre you the owner of the code you are sending in, or do you have permission of the owner?
Yes