Migration of non-essential, experimental, sample and test data gems #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Peterson <[email protected]>
Signed-off-by: Alex Peterson <[email protected]>
Signed-off-by: Alex Peterson <[email protected]>
Signed-off-by: Alex Peterson <[email protected]>
From Atom/Feature/Common/Tools/ColorGrading Signed-off-by: Alex Peterson <[email protected]>
From Atom/Feature/Common/Assets/LightingPresets Signed-off-by: Alex Peterson <[email protected]>
From Gems/AtomLyIntegration/CommonFeatures/Assets/Objects/Hermanubis Signed-off-by: Alex Peterson <[email protected]>
Signed-off-by: Alex Peterson <[email protected]>
Signed-off-by: Alex Peterson <[email protected]>
Signed-off-by: Alex Peterson <[email protected]>
Signed-off-by: Alex Peterson <[email protected]>
Signed-off-by: Alex Peterson <[email protected]>
Signed-off-by: Alex Peterson <[email protected]>
Signed-off-by: Alex Peterson <[email protected]>
Signed-off-by: Alex Peterson <[email protected]>
Signed-off-by: Alex Peterson <[email protected]>
Signed-off-by: Alex Peterson <[email protected]>
Signed-off-by: Alex Peterson <[email protected]>
moudgils
reviewed
Jan 17, 2024
Contributor
moudgils
left a comment
moudgils
left a comment
There was a problem hiding this comment.
This probably broke a lot of ASV samples. Haveyou tesed it?
Contributor
Author
I have not tested the change with AutomatedTesting or ASV yet, but this PR does not remove these Gems from o3de, I will first make the changes necessary to not break tests before removing anything from the o3de r epo. |
byrcolin
added
sig/build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Copies non-essential, sample, experimental, test data and asset heavy gems from the
o3derepo too3de-extrasto improve build times, asset processing times, bandwidth, infrastructure costs, local disk usage and SDK installer size.The gems will be made available through the
canonical.o3de.orgremote repository where they can easily be downloaded by users and then removed from the maino3derepository.This PR copies the following gems or content:
This decreases the size of the engine Gems folder from 2.03GB to 380MB and removes several of the largest assets that take the longest time for the Asset Processor to compile.
None of these gems are used in the
DefaultProjecttemplate orMinimalProjecttemplateTODO
lightingpresets/highcontrast/goegap_*inGems/Atom/Feature/Common(used by default level)Gems/Atom/Feature/Common/Assets/ColorGrading/TestDatatoAtom/TestDatagemHow was this PR tested?