xtask/kimchi-stubs: add option to build stubs w or w/o optim #3248
+94
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannywillems
force-pushed
the
dw/add-xtask-kimchi-stubs
branch
from
b387add to
3ba1e66
Compare
richardpringle
previously approved these changes
Jun 4, 2025
| None | ||
| }; | ||
|
|
||
| let target_dir = target_dir.unwrap_or("target/kimchi_stubs_build"); |
There was a problem hiding this comment.
Hmm. Might want to get the crate-directory (absolute path) and put it in front.
But then again, it might be fine. I don't like relative paths, I never remember where they are relative to
dannywillems
force-pushed
the
dw/add-xtask-kimchi-stubs
branch
from
ab25b82 to
f1d5216
Compare
This aims to replace commands used in Mina/crypto/kimchi_bindings/stubs/dune. It has been reported a few times that the proof-systems repository should be responsible to define its own build targets. The user can now generate the bindings with: ``` cargo xtask build-kimchi-stubs ``` Optimisations are activated by default, but can be disabled with ``` RUST_TARGET_FEATURE_OPTIMISATIONS=n cargo xtask \ build-kimchi-stubs \ --offline \ # optional argument --target-dir /tmp/hello-world ```
dannywillems
force-pushed
the
dw/add-xtask-kimchi-stubs
branch
from
f1d5216 to
79f9d5c
Compare
|
Getting this on my Mac: error[E0599]: no function or associated item named `new` found for struct `CpuId` in the current scope
--> xtask/src/main.rs:91:28
|
91 | let cpuid = CpuId::new();
| ^^^ function or associated item not found in `CpuId<_>`
|looks like that's not supported when targeting ARM chips? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to replace commands used in Mina/crypto/kimchi_bindings/stubs/dune. It has been reported a few times that the proof-systems repository should be responsible to define its own build targets.
The user can now generate the bindings with:
Optimisations are activated by default, but can be disabled with
@svv232 can you check that the warnings you do have on Mina/compatible now does not appear when running either
RUST_TARGET_FEATURE_OPTIMISATIONS=y cargo run -p xtask -- build-kimchi-stubsorRUST_TARGET_FEATURE_OPTIMISATIONS=n cargo run -p xtask -- build-kimchi-stubs?@richardpringle can I have your opinion on the code?
EDIT:
This patch, as a consequence, will remove the following warnings MacOS users might see: