fix: Correctly initialize Account session in API helper#50
Open
cgumb wants to merge 1 commit intonyuoss:mainfrom
Open
fix: Correctly initialize Account session in API helper#50cgumb wants to merge 1 commit intonyuoss:mainfrom
cgumb wants to merge 1 commit intonyuoss:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in src/gradescopeapi/api/api.py where the Account class was being initialized with an invalid session object.
Details
The
get_account helperfunction was incorrectly passing the function referenceget_gs_connection_sessionto the Account class constructor. It should have been passing therequests.Sessionobject returned by calling that function.This resulted in an Account instance where
self.sessionwas a function, not a session object.The fix is to correctly call
get_gs_connection_session()to pass the expected session object during initialization.Reference to the issue
This latent bug was discovered during the development and debugging of a new utility script that relied on the API's components.