Skip to content

Fix the bug of get_course_members does not work when num_submissions_column is not 3 or 4 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yhzhao343 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the bug of get_course_members does not work when num_submissions_column is not 3 or 4 #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/gradescopeapi/classes/_helpers/_course_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,11 @@ def get_course_members(soup: BeautifulSoup, course_id: str) -> list[Member]:
# name, email, role, sections?, submissions, edit, remove
# if course has sections, section column is added before number of submissions column
headers = soup.find("table", class_="js-rosterTable").find_all("th")
has_sections = any(h.text.startswith("Sections") for h in headers)
num_submissions_column = 4 if has_sections else 3
num_submissions_column = -1
for i, h in enumerate(headers):
if h.text.lower().startswith("submissions"):
num_submissions_column = i
break
Comment on lines +142 to +146
Copy link
Member

@calvinatian calvinatian Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about this some more I think we could do a search for the Edit column and take the previous element as the Submissions column. I think the edit column has a unique aria-label. This way we can remove the language dependency on the English "Sections"/"Submissions" wording.

Another option could be searching the headers for the aria-controls="DataTables_Table_0" attribute and taking the last one as the submissions column.


member_list = []

Expand Down Expand Up @@ -187,7 +190,9 @@ def get_course_members(soup: BeautifulSoup, course_id: str) -> list[Member]:
user_id = data_url.split("user_id=")[-1]

# fetch number of submissions from table cell
num_submissions = int(cells[num_submissions_column].text)
num_submissions = (
0 if num_submissions_column < 0 else int(cells[num_submissions_column].text)
)

# create Member object with all relevant info
member_list.append(
Expand Down
Loading