Skip to content

Networking and Bootstrapping configuration changes#6901

Draft
jmwample wants to merge 6 commits into
developfrom
jmwample/config-dns
Draft

Networking and Bootstrapping configuration changes#6901
jmwample wants to merge 6 commits into
developfrom
jmwample/config-dns

Conversation

@jmwample

@jmwample jmwample commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

NYM-927

This PR moves toward distilling and synchronizing the specific networking information that is needed to bootstrap connections such that the structure can be shares and re-used in both nym core applications and in VPN / discovery use cases.

This change:

  • Updates the NetworkDetails structure
    • removing the nym_vpn_api_url field (this was deprecated by the addition of nym_vpn_api_urls)
    • moves nym_vpn_api_urls and nym_api_urls into a new NetworkingSpecifics structure
    • Adds placeholder fields for internal DNS resolver and covert channel information in the networking specifics.
    • Adds mainnet defaults for the updated NetworkDetails and new NetworkingSpecifics
  • moves sandbox information from the nym-wallet-types to the nym-network-details crate to match the mainnet network details.
  • update setter and getter functions

This change is Reviewable

@vercel

vercel Bot commented Jun 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nym-explorer-v2 Error Error Jun 22, 2026 9:10pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs-nextra Ignored Ignored Preview Jun 22, 2026 9:10pm
nym-node-status Ignored Ignored Preview Jun 22, 2026 9:10pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5908667f-5874-463b-bc69-477dc50f7ba1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jmwample/config-dns

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants