Added new feature: fidelity #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nylser
requested changes
Mar 25, 2025
Owner
nylser
left a comment
nylser
left a comment
There was a problem hiding this comment.
Just one small change in the warning, otherwise it looks good
Co-authored-by: Korbinian Stein <[email protected]>
nylser
pushed a commit
that referenced
this pull request
Mar 26, 2025
* added TODO and a method for calculating the fidelity * feat: added library to calculate ground state * added hamiltonian and circuit to OptimizationResult * added ground state and fidelity flag to Job class * hamiltonian, circuit is None for FCI * hamiltonian, circuit is returned for spa * fidelity method to calculate fidelity between states * add parameter for fidelity in generate jobs * ground state method * updated execute job for calculating optimized ground state * added parameter ground state and calculate fidelity to job * changed create result to get extra column for fidelity * changed create result to get extra column for fidelity * added fidelity as argument * Changed ground state Hamiltonian to hardcore boson hamiltonian * saved normal circuit * changed ground state hamiltonian * used Circuit to calculate optimized state * deleted Hamiltonian * deleted Hamiltonian * add test and deleted unnecessary code * add molecule parameter to OptimizationResult * deleted ground_state parameter in Job * OptimizationResult returns molecule too * made get_ground_state a class method * deleted ground_state parameter from Job * added molecule from optimization result and some comments * feat: optimize fidelity code for degenerated states * chore: organize imports * added warning if num_of_atoms greater than 8 * chore: optimized code and deleted commits * chore: fix formatting * chore: changed warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature to Quanti-gin that calculates the fidelity between the states and the true ground states.
Two new methods were added: