fix: do not replace but merge Node manifest options into default options#1577
Merged
Conversation
Collaborator
|
Update: Got it, this removes all the default options as you mentioned. |
ayushmanchhabra
changed the title
ayushmanchhabra
changed the title
ayushmanchhabra
pushed a commit
that referenced
this pull request
Apr 25, 2026
🤖 I have created a release *beep* *boop* --- ## [4.17.8](v4.17.7...v4.17.8) (2026-04-25) ### Bug Fixes * **bld:** remove MacOS Plugin Helper renaming logic ([#1581](#1581)) ([43f2caa](43f2caa)) * **deps:** bump @xmldom/xmldom from 0.8.12 to 0.8.13 ([#1574](#1574)) ([becde28](becde28)) * do not replace but merge Node manifest options into default options ([#1577](#1577)) ([04dc8b7](04dc8b7)) ### Chores * **deps:** bump the gha group across 1 directory with 2 updates ([#1573](#1573)) ([70a79c4](70a79c4)) * **deps:** bump the npm group across 1 directory with 4 updates ([#1582](#1582)) ([805bb51](805bb51)) * refactor out run mode logic to @nwutils/runner ([#1579](#1579)) ([ef38439](ef38439)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if the node manifest is provided via
package.json, all of the default options get blown away due to this mutation:nw-builder/src/index.js
Line 58 in becde28
This change applies the manifest options as an override on top of the existing options.