Fix ExecuteScriptEnhanced#83
Merged
CromFr merged 2 commits intoMay 15, 2026
Merged
Conversation
- properly set the maxSize value on the NWN2ParamsList - create a NWN2Heap managed memory buffer for parameters - Add the "number of parameters" bytes at the start of the paramBuffer and set it to 0 to avoid deep delete. - Properly call the CleanParameters at the end of execution.
6ff2d4e to
620ca71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a script calls a ScriptParameter-related function (ClearScriptParams, AddScriptParametersXXX, or ExecuteScriptEnhanced with bClearParams = true), the game tries to inspect the parameters buffer, delete all parameters in it, and free the buffer.
Currently, if a script called by our internal ExecuteScriptEnhanced uses one of those functions, the game crashes because NWN2 cannot manage the std::vector memory used.
The changes here:
This fixes crashes when scripts use parameter management functions within ExecuteScriptEnhanced.