Add github action#24
Draft
faddat wants to merge 8 commits into
Draft
Conversation
nvmd
requested changes
May 24, 2025
Owner
There was a problem hiding this comment.
Hi! Thank you for your PR! (we'd better work this way)
There are some changes that aren't really needed, take a look at what https://github.com/nix-community/nixos-images already does.
Could you please change PR to merge into the develop and squash commits for the sake of better maintainability in the future?
Owner
There was a problem hiding this comment.
This additional configuration isn't needed.
This flake uses https://github.com/nix-community/nixos-images as a base for installer images:
- ssh is already enabled, permitting password logins
- root can login with the dynamically-generated password show on the screen
Author
|
ah, thank you! I am going to put this on draft, as I do need to fix up the action :) |
|
I'm gonna make my own PR. This one isn't great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes 2 changes:
passwordon the nixos account (to make initial setup easier)If you want me to take out the password part but keep the action lmk. Also feel free to copy pasta the action :)