Skip to content

Add github action#24

Draft
faddat wants to merge 8 commits into
nvmd:mainfrom
faddat:faddat/action
Draft

Add github action#24
faddat wants to merge 8 commits into
nvmd:mainfrom
faddat:faddat/action

Conversation

@faddat
Copy link
Copy Markdown

@faddat faddat commented May 24, 2025

This makes 2 changes:

  • adds a github action that will run each time changes are made
  • sets a default password, password on the nixos account (to make initial setup easier)

If you want me to take out the password part but keep the action lmk. Also feel free to copy pasta the action :)

Copy link
Copy Markdown
Owner

@nvmd nvmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for your PR! (we'd better work this way)

There are some changes that aren't really needed, take a look at what https://github.com/nix-community/nixos-images already does.

Could you please change PR to merge into the develop and squash commits for the sake of better maintainability in the future?

Comment thread flake.nix
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This additional configuration isn't needed.
This flake uses https://github.com/nix-community/nixos-images as a base for installer images:

  • ssh is already enabled, permitting password logins
  • root can login with the dynamically-generated password show on the screen

@faddat
Copy link
Copy Markdown
Author

faddat commented May 25, 2025

ah, thank you! I am going to put this on draft, as I do need to fix up the action :)

@faddat faddat marked this pull request as draft May 25, 2025 11:55
@umbrageodotus
Copy link
Copy Markdown

I'm gonna make my own PR. This one isn't great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants