chore: add formatter#139
Conversation
1417d98 to
c6e9bdf
Compare
|
I just noticed that |
c6e9bdf to
fdeb84a
Compare
|
@nvmd could we please make a bit of progress regarding the formatting? This PR, and:
All try to format the project and it is a mess. I'm trying to merge multiple pull requests locally to test them and help with the project in general but it becomes too hard with all the merge conflicts related to formatting. |
|
I was looking at the other PRs you mentioned and saw that you suggested adding a .git-blame-ignore-revs file like in nixpkgs. I can do that here too later today! |
|
I've added the |
|
Hi @doronbehar thanks for bringing this issue up. The formatting does seem like a hot topic indeed. However, regardless of how hot it is, I can't for the sake of further maintainability merge it together with some irrelevant changes. The examples you include here: mix formatting with the other changes on the commit level, effectively hiding them; formatting being a part of a PR otherwise needed review feature by feature. This feedback was provided to the authors of the corresponding PRs. That said, I don't quite understand the pressure you're trying to put on me personally. Though I guess it's done with good intentions and your help with the project would be greatly appreciated in any case. |
Thanks @limwa! I did completely forget about this feature! And this PR being the cleanest of the formatting ones, sorry! No any more questions from my side. |
|
Thanks @nvmd :). Hope to be able to further help soon with testings. |
Hi, I noticed that the project uses
nixpkgs-fmtin its devShells, but doesn't set a formatter in the flake. I thought it could be useful to set it, and while I'm at it, I also decided to add an action that checks the formatting of all files.nixpkgs-fmtas the formatter in the flake. Makes it so thatnix fmt .automatically invokesnixpkgs-fmt.developormain.