Conversation
…hind HOLOLINK_BUILD_TESTS - Move include(hololink_deps/pybind11) and linux_sub_frame_imx274_player / sub_frame_imx274_player into if(HOLOLINK_BUILD_PYTHON) guards so examples build without Python when HOLOLINK_BUILD_PYTHON=OFF. - Wrap all add_test()/set_tests_properties() in if(HOLOLINK_BUILD_TESTS) so example binaries can be built without registering CTests (which require HSB hardware to pass). Signed-off-by: Alexis Girault <agirault@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows building examples without Python and without hardware-dependent tests
linux_sub_frame_imx274_player,sub_frame_imx274_player) intoif(HOLOLINK_BUILD_PYTHON)guardsadd_test()inif(HOLOLINK_BUILD_TESTS)so example binaries can be built without registering CTests (which require HSB hardware to pass)