Conversation
When hololink is consumed via CMake FetchContent, CMAKE_SOURCE_DIR points to the consuming project, not the hololink source tree. Use hololink_SOURCE_DIR (set by FetchContent) so HOLOLINK_REL_PATH resolves correctly in both standalone and subdirectory builds. Signed-off-by: Alexis Girault <agirault@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
HOLOLINK_REL_PATHinsrc/hololink/emulation/CMakeLists.txtto use${hololink_SOURCE_DIR}instead of${CMAKE_SOURCE_DIR}: when consumed via CMake FetchContent,CMAKE_SOURCE_DIRpoints to the consuming project, breaking the include path forhololink_deps/dlpack.cmakeThe top-level
CMakeLists.txtwas already fixed in 2.6.0-EA; this fixes the remaining occurrence in the emulation subsystem