Skip to content

fix: stop requesting permission unless necessary#28

Merged
Marc-Antoine-Soucy merged 1 commit intomainfrom
dev/maso/fixrequestpermission
Mar 14, 2025
Merged

fix: stop requesting permission unless necessary#28
Marc-Antoine-Soucy merged 1 commit intomainfrom
dev/maso/fixrequestpermission

Conversation

@Marc-Antoine-Soucy
Copy link
Contributor

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

Fixed an issue where the permission value would become false when you did some operations like GetInitialLocationOrDefault because it would request permissions the value for the permission would become temporarily false. Also, repeatedly calling the api.

Impact on version

  • Major (Public API was modified.)
    • Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
    • Public members were removed or renamed.
    • Public method signatures were changed or renamed.
  • Minor (Public API was extended.)
    • Public constructs, members, or overloads were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (The library is unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.

PR Checklist

  • Your conventional commits are aligned with the Impact on version section.
  • Documentation is up to date.
    • Content of README.md is up to date.
    • XML documentation is up to date.
  • The BREAKING_CHANGES.md document is up to date.
    • Create a new Major.0.0 header if you do a Major change and list the breaking changes.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@Marc-Antoine-Soucy Marc-Antoine-Soucy merged commit 2c087de into main Mar 14, 2025
3 checks passed
@Marc-Antoine-Soucy Marc-Antoine-Soucy deleted the dev/maso/fixrequestpermission branch March 14, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants