Skip to content

fix!: remove UI dependencies on abstraction extensions#27

Merged
Marc-Antoine-Soucy merged 1 commit intomainfrom
dev/maso/abstractextensions
Feb 20, 2025
Merged

fix!: remove UI dependencies on abstraction extensions#27
Marc-Antoine-Soucy merged 1 commit intomainfrom
dev/maso/abstractextensions

Conversation

@Marc-Antoine-Soucy
Copy link
Contributor

GitHub Issue: #

Proposed Changes

  • Bug fix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)
  • Build or CI related changes
  • Documentation content changes
  • Other, please describe:

Description

I removed reference to UI project from extensions that did not depend on these.

GeolocatorService.Reactive.Uno.WinUI was removed
Reference to GeolocatorService from GeolocatorService.Reactive was removed.

Impact on version

  • Major (Public API was modified.)
    • Public constructs (class, struct, delegate, enum, etc.) were removed or renamed.
    • Public members were removed or renamed.
    • Public method signatures were changed or renamed.
  • Minor (Public API was extended.)
    • Public constructs, members, or overloads were added.
  • Patch (Public API was unchanged.)
    • A bug in behavior was fixed.
    • Documentation was changed.
  • None (The library is unchanged.)
    • Only code under the build folder was changed.
    • Only code under the .github folder was changed.

PR Checklist

  • Your conventional commits are aligned with the Impact on version section.
  • Documentation is up to date.
    • Content of README.md is up to date.
    • XML documentation is up to date.
  • The BREAKING_CHANGES.md document is up to date.
    • Create a new Major.0.0 header if you do a Major change and list the breaking changes.
  • Tested on all relevant platforms

Other information

Internal Issue (If applicable):

@Marc-Antoine-Soucy Marc-Antoine-Soucy force-pushed the dev/maso/abstractextensions branch from 92fcb7c to 37852a5 Compare February 20, 2025 15:33
@Marc-Antoine-Soucy Marc-Antoine-Soucy merged commit c36a3e0 into main Feb 20, 2025
3 checks passed
@Marc-Antoine-Soucy Marc-Antoine-Soucy deleted the dev/maso/abstractextensions branch February 20, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants