Conversation
jeanplevesque
requested changes
Mar 16, 2021
src/DynamicMvvm.Abstractions/ViewModel/IViewModel.Extensions.Commands.cs
Outdated
Show resolved
Hide resolved
src/DynamicMvvm.Abstractions/ViewModel/IViewModel.Extensions.Commands.cs
Outdated
Show resolved
Hide resolved
src/DynamicMvvm.Abstractions/ViewModel/IViewModel.Extensions.Commands.cs
Show resolved
Hide resolved
src/DynamicMvvm.Abstractions/ViewModel/IViewModel.Extensions.Commands.cs
Outdated
Show resolved
Hide resolved
| var receivedParameter = default(TestEntity); | ||
| var viewModel = new ViewModelBase(serviceProvider: _serviceProvider); | ||
|
|
||
| var command = viewModel.GetItemCommandFromTask<TestEntity>(async (ct, p) => receivedParameter = p); |
Member
There was a problem hiding this comment.
You should have a test that validates that all instances returned by this method are different, even when using the same name.
| public static IDynamicCommand GetItemCommandFromTask<TParameter>( | ||
| this IViewModel viewModel, Func<CancellationToken, TParameter, Task> execute, | ||
| Func<IDynamicCommandBuilder, IDynamicCommandBuilder> configure = null, | ||
| [CallerMemberName] string name = null |
Member
There was a problem hiding this comment.
this parameter could be renamed to namePrefix because that's what it really is
| public IDynamicCommand MyCommandFromTaskWithParameter => this.GetCommandFromTask<int>(ExecuteMyTaskWithParameter); | ||
| private async Task ExecuteMyTaskWithParameter(CancellationToken ct, int parameter) => Task.CompletedTask; | ||
|
|
||
| // This will create and attach a new IDynamicCommand named "MyCommandForItemFromTask + GUID" |
Member
There was a problem hiding this comment.
Instead of repeating the same thing as before, I would just refer to GetCommandFromTask and explain what the ItemCommand does differently.
Member
There was a problem hiding this comment.
I think this might be the best strategy for the XML doc as well (if possible).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
Proposed Changes
What is the current behavior?
What is the new behavior?
Checklist
Please check if your PR fulfills the following requirements:
Other information