Fix test_process_features float conversion - #2314
Open
KyleFromNVIDIA wants to merge 1 commit into
Open
Conversation
The conversion from float to string lost the behavior of tolerating small deltas due to floating point arithmetic error. Convert back to a float before comparison in order to get the tolerance back.
Author
|
/ok to test be72ad0 |
Contributor
|
/ok to test be72ad0 |
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/Morpheus
that referenced
this pull request
Sep 29, 2025
The conversion from float to string lost the behavior of tolerating small deltas due to floating point arithmetic error. Convert back to a float before comparison in order to get the tolerance back. Backports nv-morpheus#2314
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The conversion from float to string lost the behavior of tolerating small deltas due to floating point arithmetic error. Convert back to a float before comparison in order to get the tolerance back.
By Submitting this PR I confirm: