fix: fenced code block indentation#143
Open
adamdehaven wants to merge 1 commit intonuxt-content:mainfrom
Open
Conversation
87a9194 to
efb7275
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note
@farnabaz this will need to be picked up in @nuxtjs/mdc once verified and released.
Fixes a bug where a fenced code block at column 0 inside a MDC block component had its content indentation stripped when an indented child component appeared earlier in the same container block.
Resolves nuxt-content/mdc#483
Reproduction
Paste the following into the https://github.com/nuxt-content/mdc playground (dev server)
The
::containerat 2-space indent causes the tokenizer to setcontainerIndentSize = 2. From that point on,dentendIndentedCommponentandattemptIntentedCommponentwere unconditionally callingfactorySpaceto strip up tocontainerIndentSize + 1spaces from every subsequent line, including lines inside a code fence that was opened at column 0. The guard againstvisitingCodeFencedhappened insidelineStartAfterPrefix, which is called after the spaces were already consumed.Fix
Track whether the current fence's opening line itself had spaces stripped (
codeFenceStripped).When
visitingCodeFenced && !codeFenceStripped, skip thefactorySpacecall entirely so code content at column 0 is passed through untouched. Fences opened atcontainerIndentSizeindent (e.g. yaml props blocks) continue to work correctly since their opening lines do go through stripping.